Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Updated invalid test for binary files #33

Merged
merged 1 commit into from

2 participants

@damondanieli

The assertion was testing answer === answer instead
of checking the original message.

Binary files are getting changed between set and get. The
assertion in the tests was not checking this.

@damondanieli damondanieli Updated invalid test for binary files
The assertion was testing answer === answer instead
of checking the original message.
d17466a
@3rd-Eden
Owner

Ouch, thanks for noticing

@3rd-Eden 3rd-Eden merged commit f2faf12 into from
@3rd-Eden
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 23, 2012
  1. @damondanieli

    Updated invalid test for binary files

    damondanieli authored
    The assertion was testing answer === answer instead
    of checking the original message.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  tests/memcached-get-set.test.js
View
2  tests/memcached-get-set.test.js
@@ -287,7 +287,7 @@ module.exports = {
++callbacks;
assert.ok(!error);
- assert.ok(answer.toString('binary') === answer.toString('binary'));
+ assert.ok(answer.toString('binary') === message.toString('binary'));
memcached.end(); // close connections
});
});
Something went wrong with that request. Please try again.