Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0 gives "regexps is not defined" error #113

Closed
speedfirst opened this issue Jul 5, 2017 · 7 comments
Closed

2.2.0 gives "regexps is not defined" error #113

speedfirst opened this issue Jul 5, 2017 · 7 comments

Comments

@speedfirst
Copy link

speedfirst commented Jul 5, 2017

once require('useragent')(), you will see

ReferenceError: regexps is not defined
    at updating (/------/node_modules/useragent/index.js:22:15)
    at parsing (//------/node_modules/useragent/lib/update.js:39:11)
    at Object.generate (/------/node_modules/useragent/lib/update.js:214:3)
    at Object.parse (/------/node_modules/useragent/lib/update.js:174:11)
    at reading (/------/node_modules/useragent/lib/update.js:38:17)
    at /------/node_modules/async-listener/glue.js:188:31
    at tryToString (fs.js:499:3)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:487:12)

my node is v8.0.0

after rolling back to v2.1.13, it works

@speedfirst speedfirst changed the title 2.2.0 gives error 2.2.0 gives "regexps is not defined" error Jul 5, 2017
@Senseye
Copy link

Senseye commented Jul 7, 2017

index.js is missing variable declarations :(

@jwarkentin
Copy link

Yeah, this version is completely broken. Crashes my app the moment it starts due to the missing variable declaration. 6b84fdb is the commit that broke it.

@26medias
Copy link

It's been 5 days.
Will the author fix it?

@3rd-Eden
Copy link
Owner

Author is looking at various of options.

@speedfirst
Copy link
Author

Wondering why this broken version can pass tests ?

@3rd-Eden
Copy link
Owner

There is no test for auto update because it depends on an external data source that doesn't always change making it impossible to create a test that always works when you run it.

@3rd-Eden
Copy link
Owner

Fixed in latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants