Icons for spaces #268
Merged
Icons for spaces #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange and title attribute to compensate.
… fix for subsubmenu on hover.
…oks better and fits concept of 'target audience'
guicassolato
previously approved these changes
Oct 31, 2018
thomasmaas
added
jenkins
doc-req
josemigallas
previously approved these changes
Oct 31, 2018
josemigallas
dismissed stale reviews from guicassolato and themself
via
accf61a
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
Coverage ? 92.59%
=========================================
Files ? 2341
Lines ? 74860
Branches ? 0
=========================================
Hits ? 69313
Misses ? 5547
Partials ? 0Continue to review full report at Codecov.
|
guicassolato
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this pull request is to make the space switcher quicker to navigate by giving visual guidance in the form of an an icon for each space (type). These icons are repeated on the dashboard to make a visual connection between the dashboard sections and the spaces.
This branch has been deployed on https://3scale-admin.poc-sd.staging.3sca.net
admin:nsvmy2ff
blue icon like in side nav to make it easier to see current space:
