From 248d22c81d38cf32d739d751918461f66cba4cf6 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Fri, 30 Aug 2024 09:22:18 +0100 Subject: [PATCH 1/3] test: Print all step outputs --- .github/workflows/get-terraform-dir.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/get-terraform-dir.yaml b/.github/workflows/get-terraform-dir.yaml index db617db..ff50ea1 100644 --- a/.github/workflows/get-terraform-dir.yaml +++ b/.github/workflows/get-terraform-dir.yaml @@ -53,7 +53,12 @@ jobs: **/*.hcl dir_names: true + - name: Outputs + run: | + echo '${{ toJSON(steps.get-terraform-sum.outputs)}}' + - name: Terraform directory summary + # TODO step running anyway. if: ${{ steps.get-terraform-sum.outputs.all_changed_files != '[]' }} run: | echo "# :white_check_mark: Terraform file changes detected" >> $GITHUB_STEP_SUMMARY From fb04130274089bc6ae7f129fcb376f6d0b170f50 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Fri, 30 Aug 2024 09:40:21 +0100 Subject: [PATCH 2/3] fix(get-terraform-dir): Change the output used in the summary expression Terraform directory summary was running, even when terraform changes had not been made. The condition has been changed to use check for a non zero value in `all_changed_files_count`. --- .github/workflows/get-terraform-dir.yaml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/get-terraform-dir.yaml b/.github/workflows/get-terraform-dir.yaml index ff50ea1..3e5e108 100644 --- a/.github/workflows/get-terraform-dir.yaml +++ b/.github/workflows/get-terraform-dir.yaml @@ -57,9 +57,8 @@ jobs: run: | echo '${{ toJSON(steps.get-terraform-sum.outputs)}}' - - name: Terraform directory summary - # TODO step running anyway. - if: ${{ steps.get-terraform-sum.outputs.all_changed_files != '[]' }} + - name: Terraform directory summary - changes + if: ${{ steps.get-terraform-sum.outputs.all_changed_files_count != 0 }} run: | echo "# :white_check_mark: Terraform file changes detected" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY @@ -67,9 +66,9 @@ jobs: echo "" >> $GITHUB_STEP_SUMMARY printf '%s\n' ${{ steps.get-terraform-sum.outputs.all_changed_files }} >> $GITHUB_STEP_SUMMARY - - name: Terraform directory summary - if: ${{ steps.get-terraform-sum.outputs.all_changed_files == '[]' }} + - name: Terraform directory summary - no changes + if: ${{ steps.get-terraform-sum.outputs.all_changed_files_count == 0 }} run: | echo "# :negative_squared_cross_mark: Terraform file changes not detected" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY - echo "Terraform has not been changed." >> $GITHUB_STEP_SUMMARY + echo "Terraform has not been changed on this run" >> $GITHUB_STEP_SUMMARY From 3530fb7dbf43544f941aa34f86070af888e33ba3 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Fri, 30 Aug 2024 09:46:29 +0100 Subject: [PATCH 3/3] fix(get-terraform-dir): Minor change to summary text --- .github/workflows/get-terraform-dir.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/get-terraform-dir.yaml b/.github/workflows/get-terraform-dir.yaml index 3e5e108..437e0b5 100644 --- a/.github/workflows/get-terraform-dir.yaml +++ b/.github/workflows/get-terraform-dir.yaml @@ -53,10 +53,6 @@ jobs: **/*.hcl dir_names: true - - name: Outputs - run: | - echo '${{ toJSON(steps.get-terraform-sum.outputs)}}' - - name: Terraform directory summary - changes if: ${{ steps.get-terraform-sum.outputs.all_changed_files_count != 0 }} run: | @@ -71,4 +67,4 @@ jobs: run: | echo "# :negative_squared_cross_mark: Terraform file changes not detected" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY - echo "Terraform has not been changed on this run" >> $GITHUB_STEP_SUMMARY + echo "Terraform files have not been changed on this run" >> $GITHUB_STEP_SUMMARY