From 0b49ba5157adbfa68f0f9921b3b885b340274263 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Thu, 13 Feb 2025 10:51:28 +0000 Subject: [PATCH 1/3] refactor(checks): Remove pull_request_target event --- .github/workflows/wait-for-checks.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/wait-for-checks.yaml b/.github/workflows/wait-for-checks.yaml index fa2fd36..c6ac05d 100644 --- a/.github/workflows/wait-for-checks.yaml +++ b/.github/workflows/wait-for-checks.yaml @@ -4,9 +4,6 @@ on: pull_request: types: [opened, edited, synchronize] branches: [main] - pull_request_target: - types: [opened, edited, synchronize] - branches: [main] # Disable permissions for all available scopes permissions: {} @@ -17,7 +14,6 @@ concurrency: jobs: enforce-all-checks: - if: ${{ github.event_name == 'pull_request' }} permissions: checks: read runs-on: ubuntu-latest From a4953963768d1ce1abe2cf40b4338ea2973d4fb9 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Thu, 13 Feb 2025 10:52:39 +0000 Subject: [PATCH 2/3] refactor: Add reopened event type to all pr workflows --- .github/workflows/dependency-review.yaml | 2 +- .github/workflows/pr-title.yaml | 4 ++-- .github/workflows/wait-for-checks.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/dependency-review.yaml b/.github/workflows/dependency-review.yaml index 2d7dfe9..7ddedf5 100644 --- a/.github/workflows/dependency-review.yaml +++ b/.github/workflows/dependency-review.yaml @@ -7,7 +7,7 @@ name: Dependency Review on: pull_request: - types: [opened, synchronize] + types: [opened, reopened, synchronize] branches: [main] # Disable permissions for all available scopes diff --git a/.github/workflows/pr-title.yaml b/.github/workflows/pr-title.yaml index b93ac1d..992b26b 100644 --- a/.github/workflows/pr-title.yaml +++ b/.github/workflows/pr-title.yaml @@ -2,8 +2,8 @@ name: Validate PR title on: pull_request: - types: [opened, edited, synchronize] - #branches: [main] + types: [opened, edited, reopened, synchronize] + branches: [main] workflow_call: {} # Disable permissions for all available scopes diff --git a/.github/workflows/wait-for-checks.yaml b/.github/workflows/wait-for-checks.yaml index c6ac05d..2399fc7 100644 --- a/.github/workflows/wait-for-checks.yaml +++ b/.github/workflows/wait-for-checks.yaml @@ -2,7 +2,7 @@ name: Checks on: pull_request: - types: [opened, edited, synchronize] + types: [opened, edited, reopened, synchronize] branches: [main] # Disable permissions for all available scopes From 619f4e40886d477c508b43d1116042655fc1cc42 Mon Sep 17 00:00:00 2001 From: chris3ware <36608309+chris3ware@users.noreply.github.com> Date: Thu, 13 Feb 2025 10:53:40 +0000 Subject: [PATCH 3/3] refactor: Add white space exclusions for diff files to editorconfig --- .editorconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.editorconfig b/.editorconfig index 098e8f2..137e978 100644 --- a/.editorconfig +++ b/.editorconfig @@ -12,6 +12,10 @@ charset = utf-8 trim_trailing_whitespace = true insert_final_newline = true +# Do not trim trailing whitespace on diff files as it can be used for alignment +[*.diff] +trim_trailing_whitespace = false + # Do not trim trailing whitespace on Markdown files as double space can be used # for a newline [*.md]