New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable __MODBUSMASTER_DEBUG__ mode by default #43

Merged
merged 3 commits into from Sep 11, 2016

Conversation

Projects
None yet
2 participants
@kintel
Contributor

kintel commented Sep 9, 2016

Also made debug pins configurable.

@4-20ma

This comment has been minimized.

Show comment
Hide comment
@4-20ma

4-20ma Sep 10, 2016

Owner

Interested in the PR. I'll review and test out.

Owner

4-20ma commented Sep 10, 2016

Interested in the PR. I'll review and test out.

Show outdated Hide outdated ModbusMaster.cpp
Show outdated Hide outdated ModbusMaster.cpp
Show outdated Hide outdated ModbusMaster.cpp
@4-20ma

This comment has been minimized.

Show comment
Hide comment
@4-20ma

4-20ma Sep 10, 2016

Owner

Please verify missing ( and resolve. Thanks.

Owner

4-20ma commented Sep 10, 2016

Please verify missing ( and resolve. Thanks.

@kintel

This comment has been minimized.

Show comment
Hide comment
@kintel

kintel Sep 10, 2016

Contributor

Forgot to test with debug turned on :/
Merged with master and fixed missing '('.

Contributor

kintel commented Sep 10, 2016

Forgot to test with debug turned on :/
Merged with master and fixed missing '('.

@4-20ma 4-20ma merged commit 220e305 into 4-20ma:master Sep 11, 2016

@4-20ma

This comment has been minimized.

Show comment
Hide comment
@4-20ma

4-20ma Sep 11, 2016

Owner

LGTM.

Owner

4-20ma commented Sep 11, 2016

LGTM.

@4-20ma 4-20ma changed the title from Fix #35 - disable debug mode by default. to Disable debug mode by default Sep 11, 2016

@4-20ma 4-20ma changed the title from Disable debug mode by default to Disable __MODBUSMASTER_DEBUG__ mode by default Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment