Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable __MODBUSMASTER_DEBUG__ mode by default #43

Merged
merged 3 commits into from Sep 11, 2016
Merged

Conversation

@kintel
Copy link
Contributor

@kintel kintel commented Sep 9, 2016

Also made debug pins configurable.

@4-20ma
Copy link
Owner

@4-20ma 4-20ma commented Sep 10, 2016

Interested in the PR. I'll review and test out.

pinMode(4, OUTPUT);
pinMode(5, OUTPUT);
pinMode(__MODBUSMASTER_DEBUG_PIN_A__, OUTPUT);
pinMode__MODBUSMASTER_DEBUG_PIN_B__, OUTPUT);

This comment has been minimized.

@4-20ma

4-20ma Sep 10, 2016
Owner

Appears to be missing (.

#endif
}
else
{
#if __MODBUSMASTER_DEBUG__
digitalWrite(5, true);
digitalWrite__MODBUSMASTER_DEBUG_PIN_B__, true);

This comment has been minimized.

@4-20ma

4-20ma Sep 10, 2016
Owner

Appears to be missing (.

#endif
if (_idle)
{
_idle();
}
#if __MODBUSMASTER_DEBUG__
digitalWrite(5, false);
digitalWrite__MODBUSMASTER_DEBUG_PIN_B__, false);

This comment has been minimized.

@4-20ma

4-20ma Sep 10, 2016
Owner

Appears to be missing (.

@4-20ma
Copy link
Owner

@4-20ma 4-20ma commented Sep 10, 2016

Please verify missing ( and resolve. Thanks.

@kintel
Copy link
Contributor Author

@kintel kintel commented Sep 10, 2016

Forgot to test with debug turned on :/
Merged with master and fixed missing '('.

@4-20ma 4-20ma merged commit 220e305 into 4-20ma:master Sep 11, 2016
@4-20ma
Copy link
Owner

@4-20ma 4-20ma commented Sep 11, 2016

LGTM.

@4-20ma 4-20ma changed the title Fix #35 - disable debug mode by default. Disable debug mode by default Sep 11, 2016
@4-20ma 4-20ma changed the title Disable debug mode by default Disable __MODBUSMASTER_DEBUG__ mode by default Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.