New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with MEW Contract manager #138

Closed
Samyoul opened this Issue Oct 23, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@Samyoul
Copy link
Contributor

Samyoul commented Oct 23, 2017

With EAL active a user is not able to select from the existing contract list.

myetherwallet com

With EAL deactivated MEW works as expected.

myetherwallet com 1
myetherwallet com 2

@409H Are you able to replicate this?

@409H 409H added the bug label Oct 23, 2017

@409H

This comment has been minimized.

Copy link
Owner

409H commented Oct 23, 2017

@Samyoul Good find - yep, I can replicate

I think the POA should be to not do the address logic for EAL if an li has an attribute ng-repeat. What do you think?

@Samyoul

This comment has been minimized.

Copy link
Contributor

Samyoul commented Oct 23, 2017

The current structure with EAL is:

<ul class="dropdown-menu dropdown-menu-left" ng-show="dropdownExistingContracts">
   <!-- ngRepeat: abi in ajaxReq.abiList track by $index -->
	<li ng-repeat="abi in ajaxReq.abiList track by $index" class="ng-scope">
		<a ng-click="selectExistingAbi($index)" class="ng-binding">300 - Warrior for Battle Contract 
			<small class="mono ng-binding">
				<a
				title="See this address on the blockchain explorer"
				href="https://etherscan.io/address/0xaEc98A708810414878c3BCDF46Aad31dEd4a4557"
				class="ext-etheraddresslookup-link ext-etheraddresslookup-link-highlight"
				target="_blank"
				>0xaEc98A708810414878c3BCDF46Aad31dEd4a4557</a>
			</small>
		</a>
	</li>
	...
</ul>

I think the POA should be to not do the address logic for EAL if an li has an attribute ng-repeat. What do you think?

I think that should fix this issue, but will why does injecting the <a> into the HTML cause this issue?


Structure without EAL:

<li ng-repeat="abi in ajaxReq.abiList track by $index" class="ng-scope">
    <a ng-click="selectExistingAbi($index)" class="ng-binding">300 - Warrior for Battle Contract 
        <small class="mono ng-binding">0xaEc98A708810414878c3BCDF46Aad31dEd4a4557</small>
    </a>
</li>
@Samyoul

This comment has been minimized.

Copy link
Contributor

Samyoul commented Oct 23, 2017

I think that the bug is related to the application JS firing before Angular can do its thing, because manually altering the HTML doesn't give this issue.

I think your idea handles this bug as gracefully as possible.

Is it possible to defer the execution of the application JS until after the page JS has finished?

@409H

This comment has been minimized.

Copy link
Owner

409H commented Oct 23, 2017

Is it possible to defer the execution of the application JS until after the page JS has finished?

Yep, should be able to modify this block in DomManipulator

window.addEventListener("load", function() {
    let objEtherAddressLookup = new EtherAddressLookup();
});
@409H

This comment has been minimized.

Copy link
Owner

409H commented Oct 24, 2017

Will be looking at this tonight 1900 (GMT timezone)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment