New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'warning' page doesn't load consistently. #22

Closed
dylandamsma opened this Issue Jul 11, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@dylandamsma
Copy link

dylandamsma commented Jul 11, 2017

I've tried 10 malicious urls listed in the blacklist database and often had the 'warning screen' not trigger and was able to navigate the fake website freely. As I'm not technical, not sure what could cause this, however you may want to look into it.

@409H 409H self-assigned this Jul 11, 2017

@409H 409H added the bug label Jul 11, 2017

@409H

This comment has been minimized.

Copy link
Owner

409H commented Jul 11, 2017

Thanks - looking into it now

@409H

This comment has been minimized.

Copy link
Owner

409H commented Jul 11, 2017

What domains were you able to browse?

@dylandamsma

This comment has been minimized.

Copy link

dylandamsma commented Jul 11, 2017

myetherwaillet.com - was one of them, the warning page did not fire, until a few refreshes. It seems to mainly happen on the first visit when you installed the chrome extension only a few minutes ago, but was able to reproduce a second time for the site. Only on the third time loading the page it warned me. (there were about 20min between installing extension and visiting site)

@409H

This comment has been minimized.

Copy link
Owner

409H commented Jul 11, 2017

Thanks for the info - will have a fix out shortly as soon as I can reproduce it

@dylandamsma

This comment has been minimized.

Copy link

dylandamsma commented Jul 11, 2017

Try creating a new person in chrome, install the extension on that new chrome profile, enable it, turn on the blacklist, wait for a bit while browser is open and then in a new tab navigate to that address. -- This will emulate a new user.

P.s. I'm sending some new imagery your way you can use for the chrome extension screenshots on the chrome store and will add this to our safety guide for beginners on cryptominded.com

409H pushed a commit that referenced this issue Jul 11, 2017

Harry Denley
Issue #22 - Added logic to fetch/check for updates on init of the ext…
…ension. This should fix the syncing issues

409H pushed a commit that referenced this issue Jul 11, 2017

409H pushed a commit that referenced this issue Jul 11, 2017

Harry Denley
Merge branch 'hf-22'
* hf-22:
  Adjusted text
  Removed debug
  Added styling for the attention view
  Increased version number
  Added more thanks
  Issue #22 - Added more logic to fix syncing issues, especially on initial install
  Issue #22 - Enabled blocking blacklisted domains by default
  Sets the default explorer to etherscan for initial install
  Added thanks
  Issue #22 - Added logic to fetch/check for updates on init of the extension. This should fix the syncing issues
@409H

This comment has been minimized.

Copy link
Owner

409H commented Jul 11, 2017

Fixed in v1.3.5

@409H 409H closed this Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment