Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store redirect XML as .resources file #3

Closed
EPTamminga opened this issue Sep 12, 2019 · 1 comment · Fixed by #18
Closed

Store redirect XML as .resources file #3

EPTamminga opened this issue Sep 12, 2019 · 1 comment · Fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@EPTamminga
Copy link

EPTamminga commented Sep 12, 2019

The file redirectconfig.xml is available on a public URL, so are all the previous versions of the xml file (if you can guess the name or generate the name).

I think that this imposes a security issue, since all mappings, including wildcard settings can be spied upon.

Shouldn't the config file have an extension .resources?

@skamphuis
Copy link
Contributor

skamphuis commented Sep 12, 2019

Valid point, tnx. We'll have that fixed.

@skamphuis skamphuis added the enhancement New feature or request label Sep 12, 2019
@skamphuis skamphuis self-assigned this Sep 12, 2019
skamphuis added a commit to skamphuis/DNN-SEORedirect that referenced this issue Nov 8, 2019
skamphuis added a commit that referenced this issue Nov 8, 2019
Closes #3 by renaming the configfile to .resources
@Timo-Breumelhof Timo-Breumelhof changed the title Security issue? Store redirect XML as .resources file Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants