Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for irc to irc notice (irc). Fixes #754 #1305

Merged
merged 1 commit into from Nov 22, 2020
Merged

Add support for irc to irc notice (irc). Fixes #754 #1305

merged 1 commit into from Nov 22, 2020

Conversation

42wim
Copy link
Owner

@42wim 42wim commented Nov 22, 2020

No description provided.

@42wim 42wim added the irc label Nov 22, 2020
@42wim 42wim added this to the 1.20.1 milestone Nov 22, 2020
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2020

Code Climate has analyzed commit 3862135 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim merged commit b24e1ba into master Nov 22, 2020
@42wim 42wim deleted the fix-754 branch November 22, 2020 21:21
@chotaire
Copy link
Contributor

chotaire commented Jan 1, 2021

I get it right that this doesn't bridge irc notices to Rocket.chat, right? If it is supposed to do so, then there's a bug.

@42wim
Copy link
Owner Author

42wim commented Jan 1, 2021

@chotaire this is for "irc to irc" notices, not to other bridges (as they don't support notices?)

@Mikaela
Copy link

Mikaela commented Jan 2, 2021

Matrix does, it's m.notice there.

In my opinion notices should also be bridged as normal messages when not supported as Matterbridge currently encourages ignoring https://tools.ietf.org/html/rfc1459#section-4.4.2 which can be interpreted as bots being supposed to use NOTICEs to avoid looping.

@Mikaela Mikaela mentioned this pull request Jan 2, 2021
@chotaire
Copy link
Contributor

chotaire commented Jan 2, 2021

...and so does Rocket.Chat, the command is like on IRC: /me is writing a notice. I have this feeling it gets interpreted as normal message but the content is simply posted in italic.

@Mikaela
Copy link

Mikaela commented Jan 2, 2021

/me is actually a CTCP ACTION (or specifically formatted PRIVMSG) and has nothing to do with the NOTICE command/message

@chotaire
Copy link
Contributor

chotaire commented Jan 2, 2021

@Mikaela You are absolutely right, and I've only known that since '93. I shouldn't get on Github at 10am after not having slept and then randomly post somewhere. ;)

Forget everything I've said. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants