Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unit test #137

Merged
merged 11 commits into from May 18, 2017

Conversation

Projects
None yet
4 participants
@AdrianRaFo
Copy link
Contributor

commented May 17, 2017

Fixes #131

  • auth: Missing unit test
  • gist: Missing unit test
  • user: Missing unit test

@AdrianRaFo AdrianRaFo requested review from BenFradet and juanpedromoreno May 17, 2017

adrian
@codecov-io

This comment has been minimized.

Copy link

commented May 17, 2017

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #137   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files          36     36           
  Lines         550    550           
  Branches        2      2           
=====================================
  Hits          484    484           
  Misses         66     66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02be2ca...d9e9654. Read the comment docs.

@AdrianRaFo AdrianRaFo force-pushed the arf-131-Missing-unit-test branch from 6c6b1fb to 47212ee May 17, 2017

@juanpedromoreno juanpedromoreno force-pushed the arf-131-Missing-unit-test branch from 64583a1 to 47212ee May 18, 2017

@juanpedromoreno
Copy link
Contributor

left a comment

LGTM!

adrian
@BenFradet
Copy link
Collaborator

left a comment

LGTM 👍 I have a couple of Qs though

|}""".stripMargin

val httpClientMock = httpClientMockPostOAuth[OAuthToken](
url = "http://127.0.0.1:9999/login/oauth/access_token",

This comment has been minimized.

Copy link
@BenFradet

BenFradet May 18, 2017

Collaborator

I'm curious as to why you had to specify the whole url?

|}""".stripMargin

val httpClientMock = httpClientMockPost[Gist](
url = s"gists",

This comment has been minimized.

Copy link
@BenFradet

BenFradet May 18, 2017

Collaborator

string interpolation isn't necessary

validNote,
Some("master"))
}

This comment has been minimized.

Copy link
@BenFradet

BenFradet May 18, 2017

Collaborator

was this a duplicate?

adrian

@juanpedromoreno juanpedromoreno merged commit fa439da into master May 18, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 02be2ca...d9e9654
Details
codecov/project 88% remains the same compared to 02be2ca
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@juanpedromoreno juanpedromoreno deleted the arf-131-Missing-unit-test branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.