Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upType safety at micrositeCompilingDocsTool Setting #297
Conversation
juanpedromoreno
requested review from
rafaparadela
and
fedefernandez
Jan 14, 2019
fedefernandez
approved these changes
Jan 14, 2019
fedefernandez
reviewed
Jan 14, 2019
| @@ -28,8 +28,8 @@ import sbt.Keys._ | |||
| import sbt._ | |||
| import sbt.complete.DefaultParsers.OptNotSpace | |||
| import sbtorgpolicies.github.GitHubOps | |||
| import tut.TutPlugin.autoImport._ | |||
| import mdoc.MdocPlugin.autoImport._ | |||
| import tut.TutPlugin.autoImport.{tut => tutTask, _} | |||
This comment has been minimized.
This comment has been minimized.
fedefernandez
Jan 14, 2019
Contributor
Do we need this TutPlugin autoImport and not the one for MdocImport?
This comment has been minimized.
This comment has been minimized.
rafaparadela
Jan 14, 2019
Member
import tut.TutPlugin.autoImport.{tut => tutTask, _}
import mdoc.MdocPlugin.autoImport.{mdoc => mdocTask}| @@ -43,6 +43,10 @@ trait MicrositeKeys { | |||
| final case object GHPagesPlugin extends PushWith("ghPagesPlugin") | |||
| final case object GitHub4s extends PushWith("github4s") | |||
|
|
|||
| sealed abstract class CompilingDocsTool extends Product with Serializable | |||
| final case object tut extends CompilingDocsTool | |||
| final case object mdoc extends CompilingDocsTool | |||
This comment has been minimized.
This comment has been minimized.
fedefernandez
Jan 14, 2019
Contributor
This is a bit redundant, right? I guess these can be just case object
This comment has been minimized.
This comment has been minimized.
|
This is going to fail given [error] it is imported twice in the same scope by
[error] import _root_.mdoc.MdocPlugin.autoImport._
[error] and import _root_.microsites.MicrositesPlugin.autoImport._Therefore, we might have two options:
Thoughts? |
This comment has been minimized.
This comment has been minimized.
|
Will |
This comment has been minimized.
This comment has been minimized.
|
If, as Fede suggested, |
This comment has been minimized.
This comment has been minimized.
|
|
juanpedromoreno
merged commit 62b1cfb
into
master
Jan 15, 2019
juanpedromoreno
deleted the
jp-adt-mdoc-tut
branch
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
juanpedromoreno commentedJan 14, 2019
This PR brings a new ADT that users can use at their convenience, with two possibilities:
tutormdoc.