DS-3937 Add support for styling and rows in the submission-forms.xml #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have 2 questions for this PR:
|
tdonohue
reviewed
Oct 8, 2018
| @@ -639,4 +700,8 @@ public String getInputFormNameByCollectionAndField(Collection collection, String | |||
| } | |||
| throw new DCInputsReaderException("No field configuration found!"); | |||
| } | |||
|
|
|||
| public Map<String, List<String>> getMappedValuePairs() { | |||
There was a problem hiding this comment.
Please add Javadocs to describe the structure of the "MappedValuePairs"
There was a problem hiding this comment.
good catch! at the end it was an unused caching structure introduced in an early stage of the implementation... I have removed it
|
merged with the latest code in DSpace#2187 added some javadoc and the Integration Test |
|
move to the official DSpace repository |
abollini
pushed a commit
that referenced
this pull request
Mar 3, 2020
[CST-2428] Added Advised Theses box, fix css rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of DSpace#2103
It includes: