Skip to content

Error message in content-page renders badly #168

Open
amalloy opened this Issue Nov 6, 2011 · 4 comments

2 participants

@amalloy
4clojure member
amalloy commented Nov 6, 2011

The content-page template @amcnamara wrote puts each of the page "components" into a separate div, but if there are several of them they don't always render nicely. Specifically, in @arajek's fork, at commit c5b4795e, if you visit /user/fsdfsddfsfa you get redirected to /users with an error message. But it renders on the same line as the sub-heading, instead of separately. I suspect the solution is to clear some float styles at some point in the CSS, but it's a bit beyond my comfort level to fix without breaking something else, so if @amcnamara or @gigasquid could look at it I'd appreciate it.

@gigasquid
4clojure member

I'll take a look

@amalloy
4clojure member
amalloy commented Nov 7, 2011

Thanks. No hurry though, since we don't have (and won't anytime soon) any production code that actually exhibits the problem as far as I know.

@gigasquid gigasquid was assigned Nov 8, 2011
@gigasquid
4clojure member

Looks like this is not an issue anymore? -
Going to page /user/fsdfsddfsfa gives the user a 404

bc6ddd0

@amalloy
4clojure member
amalloy commented Nov 15, 2011

Yeah, see my above remark about production code. No code currently running exhibits the problem, but if we ever add a page with both an error and a sub-heading it will look bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.