Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Get rid of whitespace, meta information that push the problem way below #170

Open
wants to merge 1 commit into from

2 participants

@srid

Also add a "go to your solution" anchor link.

(Later I intend to compress the menu to appear to the right of, instead of below, the logo).

@amalloy
Owner

When I look at a problem I haven't solved, the alignment is all messed up. See http://i.imgur.com/TweaE.png for an example.

I'm also not sure I like the "or go to your solution" link, especially since it's a "solution" link but goes to a totally different place than the "Solutions" link. Perhaps something like a button, styled the same as the Solutions button, but labelled Edit - since if I want to see the textbox on this page it's probably because I want to edit my solution. Not sure really, though - I agree it's gross that we make you scroll so much to get to the most-used part of a page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 8, 2011
  1. @srid

    Get rid of whitespace, meta information that push the problem way below

    srid authored
    Also add a "go to your solution" anchor link.
This page is out of date. Refresh to see the latest.
Showing with 21 additions and 11 deletions.
  1. +11 −2 resources/public/css/style.css
  2. +10 −9 src/foreclojure/problems.clj
View
13 resources/public/css/style.css
@@ -7,6 +7,15 @@ body {
text-align: center;
}
+div#right-title {
+ float: right;
+}
+div#title-rule {
+ clear: right;
+ margin-bottom: 5px;
+ border-bottom: 1px solid;
+}
+
img {border:none}
div.progress-bar-bg {
@@ -78,7 +87,7 @@ div.progress-bar {
#top {
width: 85%;
- padding: 15px 0px 15px 0px;
+ padding: 0px 0px 15px 0px;
margin: 0 auto;
}
div#top a {
@@ -188,7 +197,7 @@ img.gravatar{
height: 84px;
margin-left: -7px;
float:left;
- padding:15px 0px 15px 0px;
+ padding:0px 0px 15px 0px;
border: 0;
}
View
19 src/foreclojure/problems.clj
@@ -270,18 +270,19 @@ Return a map, {:message, :error, :url, :num-tests-passed}."
{:title (str _id ". " title)
:content
[:div
+ [:div {:id "right-title"}
+ [:table#tags
+ [:tr [:th "Difficulty:"] [:td (or difficulty "N/A")]]
+ [:tr [:th "Topics:"] [:td (s/join " " tags)]]]
+ ]
[:div#prob-title title]
(if-user [{:keys [solved]}]
(if (some #{(Integer. id)} solved)
- (link-to (str "/problem/solutions/" id)
- [:button#solutions-link {:type "submit"} "Solutions"])
- [:div {:style "clear: right; margin-bottom: 15px;"} " "])
- [:div {:style "clear: right; margin-bottom: 15px;"} " "])
- [:hr]
- [:table#tags
- [:tr [:td "Difficulty:"] [:td (or difficulty "N/A")]]
- [:tr [:td "Topics:"] [:td (s/join " " tags)]]]
- [:br]
+ [:div
+ (link-to (str "/problem/solutions/" id)
+ [:button#solutions-link {:type "submit"} "Solutions"])
+ "Or go to "[:a {:href "#instruct"} "your solution"]]))
+ [:div {:id "title-rule"}]
(when-not approved
[:div#submitter "Submitted by: "
(users/mailto user)])
Something went wrong with that request. Please try again.