Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Blinking animations no longer stop all at once. #186

Merged
merged 0 commits into from Dec 1, 2011

Conversation

Projects
None yet
3 participants
Contributor

daviddavis commented Dec 1, 2011

On problems pages with multiple examples, the blinking icons stop once the first one is set to green or red. Now they keep going until each is set to either red or green. I also refactored the javascript a little bit.

Owner

amalloy commented Dec 1, 2011

Sounds awesome but I'm not really qualified to review. @gigasquid or @amcnamara, can someone verify that this makes sense and pull it?

Member

gigasquid commented Dec 1, 2011

I like the blinking - but on problems that have multiple tests - like problem 26 (fibonacci seq) - If I put in a wrong answer (or nothing) - the first test fails and the others continue to blink. It seems like one the first one fails the others should stop blinking.

@daviddavis daviddavis merged commit 688d79c into 4clojure:develop Dec 1, 2011

Contributor

daviddavis commented Dec 1, 2011

It looks like github automatically closed this request after I rebased to fix my repo which got out of sync after #181. I'll open another pull request when I am done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment