New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defauls collision mask is offset 1px #519

Closed
Wend1go opened this Issue Jun 11, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@Wend1go
Copy link
Contributor

Wend1go commented Jun 11, 2018

Describe the bug

The default collisiom mask of a sprite is offset by 1px on the Y-axis.
If you create a custom collisiom mask and add 1 to the Y axis everything looks as expected.
image

Other details

GDevelop 5.0.0-beta39

@4ian

This comment has been minimized.

Copy link
Owner

4ian commented Jun 11, 2018

Seems that there is an offset indeed. I think it's just the rendering of the mask in the editor that is faulty.

@Wend1go

This comment has been minimized.

Copy link
Contributor

Wend1go commented Jun 11, 2018

It is also in the preview. the picture in the upper left corner was taken form the preview with the player standing on the black floor.

@4ian

This comment has been minimized.

Copy link
Owner

4ian commented Jun 11, 2018

Yes, I do think that the picture in the upper left corner taking from the preview is right, as there is one pixel between the character and the bottom of the image (as shown by the black border around the character in the editor), is that right? (the green colored area in my image below:
So the thing is that the red collision mask should have on extra pixel height?

untitled-1

@Wend1go

This comment has been minimized.

Copy link
Contributor

Wend1go commented Jun 11, 2018

The whole sprite seams to be shifted up by one pixel as the red box overlaps the black border.
image
The original sprite (checked in Piskel and Gimp) has 2 pixels above the head and the feet are at the very bottom of the image.

@4ian

This comment has been minimized.

Copy link
Owner

4ian commented Dec 26, 2018

FYI, this is a bug of the platformer engine (the default collision mask is ok) that will be fixed in next version :)

@4ian 4ian closed this in #827 Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment