From 76a0a7c0df1a69b3e340c9a5bba69079e77dd29f Mon Sep 17 00:00:00 2001 From: Jonas Baumann Date: Wed, 12 Jul 2017 09:20:22 +0200 Subject: [PATCH] Fix redis make error on fresh download. The redis-download-part downloads a fresh source copy of redis, where redis-build-part compiles the source. redis-build's on_update was set to false in order to speed up updates where redis is already installed and does not change. But on certain changes (such as a changed redis buildout file) buildout will reinstall the redis-download part while only running "update" on the redis-build part. Since redis-build will skip we will end up with an uncompiled redis source. In order to solve this problem we change on_update to true, so that the redis-build part is always executed. For still skipping on an already installed redis, we just probe for the src/redis-server file and only run "make" when the file is missing. --- redis/base.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/redis/base.cfg b/redis/base.cfg index 282be83..920948d 100644 --- a/redis/base.cfg +++ b/redis/base.cfg @@ -40,8 +40,8 @@ destination = ${buildout:parts-directory}/redis-${redis-settings:redis-version} [redis-build] recipe = collective.recipe.cmd on_install = true -on_update = false -cmds = cd ${redis-download:location} && make +on_update = true +cmds = cd ${redis-download:location} ; if [ ! -e "src/redis-server" ]; then make; fi [redis-ensure-var-exists]