Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing extends which breaks packages in plone 5.1.5 #155

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
2 participants
@Nachtalb
Copy link
Member

commented May 1, 2019

The test-versions-plone-5.cfg includes a version constraint for path.py, which has dropped python 2.7 in recent versions and so must not be installed. It also contains other constraints to ensure safety, they are not used everywhere though.

See https://github.com/4teamwork/ftw-buildouts/blob/776d4593457e383ca82e1eb4b180525b474286a5/test-versions-plone-5.cfg for more information.

Fix missing extends which breaks packages in plone 5.1.5
The test-versions-plone-5.cfg includes a version constraint for path.py, which has dropped python 2.7 in recent versions and so must not be installed. It also contains other constraints to ensure safety, they are not used everywhere though.

@Nachtalb Nachtalb self-assigned this May 1, 2019

@Nachtalb Nachtalb requested a review from jone May 1, 2019

@jone

jone approved these changes May 1, 2019

Copy link
Member

left a comment

Makes sense also because of consistency: all test version files have this extends.

@jone jone merged commit 2e3c0b7 into master May 1, 2019

1 check passed

CI Governor: default Task #393667 succeeded
Details

@busykoala busykoala referenced this pull request May 1, 2019

Closed

Add extension #154

@Nachtalb Nachtalb deleted the ne/fix-missing-extend-plone-5.1.5 branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.