Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a supervisor-autostart variable for instanceX sections: #176

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@lukasgraf
Copy link
Member

lukasgraf commented Jan 13, 2020

This variable allows to control supervisor autostart behavior on a per-instance basis without having to override the entire programs variable or do error-prone line removal from it.

In particular, this allows us to get rid of this fragile hack:
https://github.com/4teamwork/opengever.zug/blob/master/base-prod.cfg#L27-L35

(Tested locally with a buildout extending from production.cfg and zeoclients/2.cfg, works exactly as I intended it to)

This variable allows to control supervisor autostart behavior on
a per-instance basis without having to override the entire
'programs' variable or do error-prone line removal from it.
@lukasgraf lukasgraf requested review from buchi and jone Jan 13, 2020
production.cfg Outdated Show resolved Hide resolved
Co-Authored-By: Jonas Baumann <jone@jone.ch>
@lukasgraf lukasgraf force-pushed the lg-introduce-supervisor-autostart branch from ab389ba to 4a7f0c4 Jan 14, 2020
@lukasgraf lukasgraf merged commit 38bee99 into master Jan 14, 2020
1 check passed
1 check passed
CI Governor: default Task #496555 succeeded
Details
@lukasgraf lukasgraf deleted the lg-introduce-supervisor-autostart branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.