Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoomlevel / maplayer preferences to addressblock #25

Merged

Conversation

Projects
None yet
2 participants
@Nachtalb
Copy link
Member

commented May 20, 2019

This is in conjunction with 4teamwork/ftw.simplelayout#530

@Nachtalb

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

The tests fail because of the problem described here #24 -> was merged

@Nachtalb Nachtalb requested a review from maethu May 20, 2019

@Nachtalb Nachtalb self-assigned this May 20, 2019

@Nachtalb

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

@maethu because this will only work after 4teamwork/ftw.simplelayout#530 is available, shall this be mentioned in the readme or even have a version constraint?

@Nachtalb Nachtalb force-pushed the ne/add-zoomlevel-maplayer-preferences-to-addressblock branch from a77584e to e1f16fc May 20, 2019

Nachtalb added some commits May 20, 2019

@Nachtalb Nachtalb force-pushed the ne/add-zoomlevel-maplayer-preferences-to-addressblock branch from 5411672 to 36c80e3 May 20, 2019

@maethu

maethu approved these changes May 21, 2019

@Nachtalb

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

I have added the version constraint message in the README as discussed.

@Nachtalb Nachtalb requested a review from maethu May 21, 2019

@Nachtalb Nachtalb force-pushed the ne/add-zoomlevel-maplayer-preferences-to-addressblock branch from ac1ebcb to 46b75e1 May 21, 2019

@maethu

maethu approved these changes May 21, 2019

@Nachtalb Nachtalb force-pushed the ne/add-zoomlevel-maplayer-preferences-to-addressblock branch from 46b75e1 to 7ab546e May 21, 2019

@Nachtalb

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Last change was a correction to the simplelayout version mentioned in the readme

@Nachtalb Nachtalb merged commit 902b1f4 into master May 21, 2019

2 checks passed

CI Governor: test-plone-4.3.x.cfg Task #401150 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #401151 succeeded
Details

@Nachtalb Nachtalb deleted the ne/add-zoomlevel-maplayer-preferences-to-addressblock branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.