Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit permissions for addressblock #28

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
2 participants
@Nachtalb
Copy link
Member

commented May 21, 2019

We only want the user to see and "edit" button/link if he actually does have the permission to edit it.

@Nachtalb Nachtalb requested a review from jone May 21, 2019

@Nachtalb Nachtalb self-assigned this May 21, 2019

@Nachtalb Nachtalb force-pushed the ne/edit-permission-fix branch from 5505fb0 to c03b538 May 21, 2019

@jone
Copy link
Member

left a comment

@Nachtalb could you add a changelog entry?
Otherwise it looks good 👍

Fix edit permissions for addressblock
We only want the user to see and "edit" button/link if he actually does have the permission to edit it.

@Nachtalb Nachtalb force-pushed the ne/edit-permission-fix branch from c03b538 to ad32f8e May 22, 2019

@Nachtalb Nachtalb merged commit 098702f into master May 22, 2019

2 checks passed

CI Governor: test-plone-4.3.x.cfg Task #401620 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #401621 succeeded
Details

@Nachtalb Nachtalb deleted the ne/edit-permission-fix branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.