Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftw.file DX integration #104

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@maethu
Copy link
Member

maethu commented Nov 4, 2019

The biggest change IMHO is that the filename from a file is now based on the filename.
This ist the default behavior in plone and could be changed by exchanging it with the NameFromTitle behavior.

@maethu maethu changed the base branch from master to jone-dexterity Nov 4, 2019
@maethu maethu force-pushed the mle-file-dx branch 5 times, most recently from 79563d6 to 1cb1ee8 Nov 4, 2019
ftw/book/testing.py Show resolved Hide resolved
@maethu maethu force-pushed the mle-file-dx branch 2 times, most recently from a252867 to 6805286 Nov 4, 2019
@maethu maethu requested a review from jone Nov 4, 2019
@maethu maethu marked this pull request as ready for review Nov 4, 2019
@jone jone force-pushed the mle-file-dx branch from 6805286 to 9d1fc94 Nov 4, 2019
@jone jone changed the base branch from jone-dexterity to master Nov 4, 2019
@jone
jone approved these changes Nov 4, 2019
Copy link
Member

jone left a comment

@maethu I've added self.ensure_profile_installed('ftw.file:default') to the upgrade step.

@jone jone merged commit 45ebb36 into master Nov 4, 2019
1 check passed
1 check passed
CI Governor: test-plone-4.3.x.cfg Task #463686 succeeded
Details
@jone jone deleted the mle-file-dx branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.