Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Type" column from listing block table in PDF. #108

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@jone
Copy link
Member

jone commented Nov 6, 2019

The type column shows an icon of the mimetype of the file in the web. But we do not have those icons (font awesome) in the PDF, so the column is always empty. Therefore we just remove the column from the PDF.

Before:
Bildschirmfoto 2019-11-06 um 14 38 52
After:
Bildschirmfoto 2019-11-06 um 14 38 56

The type column shows an icon of the mimetype of the file in the web.
But we do not have those icons (font awesome) in the PDF, so the
column is always empty.
Therefore we just remove the column from the PDF.
@jone jone requested a review from 4teamwork/plone Nov 6, 2019
@jone jone merged commit 92397a5 into master Nov 6, 2019
1 check passed
1 check passed
CI Governor: test-plone-4.3.x.cfg Task #464658 succeeded
Details
@jone jone deleted the jone-listingblock-no-type branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.