Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use h2 heading chapter content and make chapter block more compact #109

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@jone
Copy link
Member

jone commented Nov 6, 2019

  • Make the block-title of a chapter (and textblocks) to be displayed as h2 in the chapter simplelayout view as this is semantically correct and looks consitent on all levels.

  • Make the chapter block more compact for improved usability.

After:
Bildschirmfoto 2019-11-06 um 15 16 03

Before:
Bildschirmfoto 2019-11-06 um 15 15 42

@jone jone requested a review from 4teamwork/plone Nov 6, 2019
@jone jone force-pushed the jone-chapter-sematic-and-display branch from 12bff91 to 7f52716 Nov 6, 2019
Copy link
Contributor

busykoala left a comment

Could you provide a screenshot?

@jone

This comment has been minimized.

Copy link
Member Author

jone commented Nov 7, 2019

@busykoala I've added screenshot. I actually made the screenshots but forgot to upload them 🙈

Copy link
Contributor

busykoala left a comment

Perfect! Looks great ;-)

…pact.

- Make the block-title of a chapter (and textblocks) to be
  displayed as h2 in the chapter simplelayout view as this is
  semantically correct and looks consitent on all levels.

- Make the chapter block more compact for improved usability.
@jone jone force-pushed the jone-chapter-sematic-and-display branch from 7f52716 to bf97f68 Nov 7, 2019
@jone

This comment has been minimized.

Copy link
Member Author

jone commented Nov 7, 2019

Rebased.

@busykoala busykoala merged commit 996a163 into master Nov 7, 2019
1 check passed
1 check passed
CI Governor: test-plone-4.3.x.cfg Task #465085 succeeded
Details
@busykoala busykoala deleted the jone-chapter-sematic-and-display branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.