Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: use external links for non-PDF content. #110

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@jone
Copy link
Member

jone commented Nov 6, 2019

When a content is linked in a book and the target content is included in the same PDF, an PDF-internal reference is used. For external resources a URL-based link is used.

When linking files, which are stored in a listing block in the book, we still want to use an external URL-based link because files are not embedded in the PDF, so that file content is not part of the PDF.

When a content is linked in a book and the target content is included
in the same PDF, an PDF-internal reference is used.
For external resources a URL-based link is used.

When linking files, which are stored in a listing block in the book,
we still want to use an external URL-based link because files are not
embedded in the PDF, so that file content is not part of the PDF.
@jone jone requested a review from 4teamwork/plone Nov 6, 2019
Copy link
Contributor

busykoala left a comment

Looks good. I did not test it manually though.

@jone jone merged commit 076e933 into master Nov 7, 2019
1 check passed
1 check passed
CI Governor: test-plone-4.3.x.cfg Task #464672 succeeded
Details
@jone jone deleted the jone-internal-link-to-file branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.