Add plone 5.1 support. #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test makes sure that ftw.book's htmlblock works outside of a book. As we are replacing the htmlblock with ftw.htmlblock, it is no longer our job to ensure that it works outside of books.
This helps so that we can keep the old stuff while rewriting to the new dexterity implementation.
This next / previous implementation does not work with the new dexterity types. I also believe that we do not use that.
I had to refactor the very old upgrade steps to no longer define upgrade step groups as the upgrade step directory directive fails when detecting the oldest version when the profile has upgrades which are grouped.
content => old AT types contents => new DX types (and convention)
Since the ftw.contenpage based tests are not yet removed we need to install ftw.contentpage's tests extras in order to not have errors because splinter testing is not available.
For loading this ZCML we need to import from ftw.book.tests, which now imports a lot of testing stuff which is not available. Therefore we can no longer support that.
This change is necessary to remove the sizes from propertiestool.xml. Since these sizes are from simplelayout they should not be in ftw.book
The buttons have to be reimplemented while TinyMCE comes with plone anyway.
In Plone 5 types must be whitelisted instead of blacklisted like in Plone 4.
This watcher triggers a shell command recooking the files whenever anything changes in resources. Otherwise the command has to be executed manually everytime one wants to see the effect in a running instance.
|
@jone, could you please:
|
Closed
jone
suggested changes
Nov 11, 2019
There was a problem hiding this comment.
There are a lot of changes in this branch that are already in master, but in different commits. So this branch needs to be rebased onto master. @busykoala could you do that?
I suggest:
git fetch
git rebase a095f9e^ --onto origin/master
| grunt.initConfig({ | ||
| pkg: grunt.file.readJSON('package.json'), | ||
| watch: { | ||
| files: ['Gruntfile.js', 'ftw/**/*.js', 'ftw/**/*.css', 'ftw/**/*.scss'], |
There was a problem hiding this comment.
@busykoala we have this problem in general in development, right? Should we find a general solution, e.g. a local tool?
| @@ -10,6 +10,8 @@ Changelog | |||
| - Remove "Type" column from listing block table in PDF. [jone] | |||
| - Fix navigation and search settings for new DX types. [jone] | |||
| - Fix chapter's title translation. [jone] | |||
| - Add Plone 5 support. [busykoala] | |||
There was a problem hiding this comment.
ftw.book 4.0.2 is already released, do you need to rebase again?
|
I close this in favour of #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Close https://github.com/4teamwork/izug.organisation/issues/1514
This is the branch #103 where the master was merged into. Therefore we can close #103 as soon as this one is going to be more stable.