Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS counters #118

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fix CSS counters #118

merged 1 commit into from Jan 6, 2020

Conversation

@djowett-ftw
Copy link
Contributor

djowett-ftw commented Dec 24, 2019

Fixes 4teamwork/izug.organisation#1727

Lightly tested due to time, but I think this is the correct approach

" To use CSS counter, it must first be initialized to a value with the counter-reset property."
That counter-reset also seems to need to be a direct ancestor.

Only the last counter-reset property was taking effect in the tag.

Therefore the section needed an ancestor in the DOM to declare a counter-reset but in the above issue the resets were done by 'uncles' not direct ancestors

      'To use CSS counter, it must first be initialized to a value with the counter-reset property.'
      Only the last counter-reset was taking effect in the <body> tag.
@djowett-ftw djowett-ftw requested review from jone and Nachtalb Dec 24, 2019
@jone
jone approved these changes Jan 6, 2020
Copy link
Member

jone left a comment

Ah voilà, thank you!

@djowett-ftw djowett-ftw merged commit 37f1d35 into master Jan 6, 2020
2 checks passed
2 checks passed
CI Governor: test-plone-4.3.x.cfg Task #487954 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #487955 succeeded
Details
@djowett-ftw djowett-ftw deleted the dj_fix_counter branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.