Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Plone 5. #60

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@jone
Copy link
Member

commented Sep 9, 2019

The test was relying on the fact that getDependenciesForProfile did not check whether the profiles actually exist. But this was changed from Plone 4 to 5, getDependenciesForProfile now verifies that the profiles actually exist.

The test is rewritten to use actually generated profiles, so that the verification passes.

Fix tests for Plone 5.
The test was relying on the fact that getDependenciesForProfile did
not check whether the profiles actually exist.
But this was changed from Plone 4 to 5, getDependenciesForProfile now
verifies that the profiles actually exist.

The test is rewritten to use actually generated profiles, so that the
verification passes.

@jone jone requested a review from mbaechtold Sep 9, 2019

@mbaechtold
Copy link
Member

left a comment

Thank you, @jone!

@jone jone merged commit 67381fe into master Sep 9, 2019

2 checks passed

CI Governor: test-plone-4.3.x.cfg Task #440998 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #440999 succeeded
Details

@jone jone deleted the jone-plone5-fix-tests branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.