Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 5.1 compatibility #34

Draft
wants to merge 8 commits into
base: master
from

Conversation

@djowett-ftw
Copy link

commented Sep 6, 2019

Close 4teamwork/ogb#48

This passes tests, but:

  • I'm not sure about the publisher work around
  • the control panel displays the status message twice for Plone 5 (or 3 times if using the blueberry theme)

Screenshot 2019-09-06 at 16 38 50

@djowett-ftw djowett-ftw requested a review from jone Sep 6, 2019

@jone
jone approved these changes Sep 9, 2019
Copy link
Member

left a comment

Looks good 👍

ftw/globalstatusmessage/tests/test_controlpanel.py Outdated Show resolved Hide resolved
@jone

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Publisher:
The publisher part is hard to test because we do not have an end-to-end test-setup for the publisher. But since there are no changes on the storage of the messages at all it should keep working. I've made a note that we will test this manually in QA.

Duplicate messages:
Could you find the reason for duplicate messages already?
I'd first test whether there are duplicates without diazo.
If not, I suspect that a diazo rule in the theme duplicates the messages somehow.

@djowett-ftw

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Publisher:

Ok - I misunderstood that part as we found in our useful corridor discussion! No problem then.

Duplicate messages:
Could you find the reason for duplicate messages already?
I'd first test whether there are duplicates without diazo.
If not, I suspect that a diazo rule in the theme duplicates the messages somehow.

Diazo is doubling the message at the top; yet to uncover how, is that a fix for now, or should I add an issue to the blueberry theme?
The message in the middle of the screen is still there with Diazo off. Does that matter?

@jone

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Diazo is doubling the message at the top; yet to uncover how, is that a fix for now, or should I add an issue to the blueberry theme?

Please add an issue; we can't fix it here.

The message in the middle of the screen is still there with Diazo off. Does that matter?

I think that was not there before and we should find the cause and remove the message in the middle.

@djowett-ftw

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

Publisher:

Ok - I misunderstood that part as we found in our useful corridor discussion! No problem then.

Duplicate messages:
Could you find the reason for duplicate messages already?
I'd first test whether there are duplicates without diazo.
If not, I suspect that a diazo rule in the theme duplicates the messages somehow.

Diazo is doubling the message at the top; yet to uncover how, is that a fix for now, or should I add an issue to the blueberry theme?
The message in the middle of the screen is still there with Diazo off. Does that matter?

@djowett-ftw

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

@djowett-ftw

This comment has been minimized.

Copy link
Author

commented Sep 13, 2019

The duplicate global status messages are a Plone issue I believe. I've raised it here plone/Products.CMFPlone#2947

Worked around it using CSS in cde161c.

@djowett-ftw djowett-ftw changed the title Work done for Plone 5.1, with issues to discuss Plone 5.1 compatibility Sep 13, 2019

@djowett-ftw djowett-ftw force-pushed the dj/plone5.1 branch from cde161c to 78c2f44 Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.