Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom root and language independent folder types #38

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@elioschmutz
Copy link
Contributor

commented May 23, 2019

This PR implements the possibility to change the default root and language independent folder types of plone.app.multilingual.

@elioschmutz elioschmutz requested a review from jone May 23, 2019

@elioschmutz elioschmutz self-assigned this May 23, 2019

@jone
Copy link
Member

left a comment

@elioschmutz it looks like there are the tests missing: you are adding a container type but I cannot see where you are using it.
Is this PR ready for review?

@elioschmutz elioschmutz force-pushed the es-allow-customize-default-language-root-types branch 2 times, most recently from 3c204eb to 07b2bf9 May 23, 2019

Implement possiblity to override the default plone.app.multilingual r…
…oot and language independent folder types

@elioschmutz elioschmutz force-pushed the es-allow-customize-default-language-root-types branch from 07b2bf9 to 60421c4 May 24, 2019

@elioschmutz

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@jone 👍 I updated the PR and added the missing tests.

@jone

jone approved these changes Jun 13, 2019

Copy link
Member

left a comment

👍

@elioschmutz elioschmutz merged commit b573253 into master Jun 13, 2019

3 checks passed

CI Governor: test-plone-4.3.x-pml-1.cfg Task #402521 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #402522 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #402523 succeeded
Details

@elioschmutz elioschmutz deleted the es-allow-customize-default-language-root-types branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.