Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select2 is not installed #43

Open
jone opened this issue Nov 8, 2019 · 4 comments

Comments

@jone
Copy link
Member

@jone jone commented Nov 8, 2019

The select2 JavaScript is not registered in the default GS profile, but in a separate one. That means when I install ftw.keywordwidget it will not work it will not work and I get a JavaScript error that .select2 is not defined.

I suggest to move the JS registration into the default profiles and eliminate the separate select2 profile which is not Plone 5 compatible anyways.

@maethu any objections?

/cc @tinagerber

@maethu

This comment has been minimized.

Copy link
Member

@maethu maethu commented Nov 8, 2019

The problem with plone 5 is that they ship a older select2 version which is not compatible with ftw.keywordwidget. If we ship select2 directly for plone5 we need to make sure it's isolated only for the keywordwidget

The ftw.keywordwidget requires at least 4.0.2, but plone provides 3.5.x which has breaking API changes regarding this widget.

@jone

This comment has been minimized.

Copy link
Member Author

@jone jone commented Nov 8, 2019

@maethu but the current implementation simply does not work. For instance: when I install ftw.news I cannot create a news listing block.
That means we probably need to ship our own isolated version then.

@maethu

This comment has been minimized.

Copy link
Member

@maethu maethu commented Nov 8, 2019

@jone Yes that's probably the best solution, updating the one from Plone is probably not really possible.

It just kinda suck to have an isolated one... but well, that way we can get it run again.

@maethu

This comment has been minimized.

Copy link
Member

@maethu maethu commented Nov 8, 2019

ohh we may have to patch it to be isolated, since it registers itself globally 😢
Maybe unter ftwSelect2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.