New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation issues. #60

Merged
merged 1 commit into from Oct 8, 2015

Conversation

Projects
None yet
1 participant
@jone
Member

jone commented Oct 8, 2015

Problem:
We used to translate the IDs of workflow states and transitions, but Plone tries to translate by the title instead of ID.

Changes:

  • States and transitions are now translated by their titles.
  • For being able to clean up, the i18nbuilder now annotates the messages
    with references to the specifications in order to track where the
    messages are used.
  • Additionally, the i18nbuilder now adds the default comment to the
    messages.
Fix translation issues.
Problem:
We used to translate the IDs of workflow states and transitions,
but Plone tries to translate by the title instead of ID.

Changes:

- States and transitions are now translated by their titles.
- For being able to clean up, the i18nbuilder now annotates the messages
  with references to the specifications in order to track where the
  messages are used.
- Additionally, the i18nbuilder now adds the default comment to the
  messages.

jone added a commit that referenced this pull request Oct 8, 2015

@jone jone merged commit 7af8ea3 into master Oct 8, 2015

1 check passed

default CI Status: 3 SUCCESS
Details

@jone jone deleted the jone-i18n-states-and-transitions-fixes branch Oct 8, 2015

jone added a commit to 4teamwork/ftw.statusmap that referenced this pull request May 18, 2016

Support ftw.lawgiver status translations.
ftw.lawgiver has changed the status message IDs in 1.6.1 in order to fix
issues with Plone translations.
The status must be translated in the Plone domain now.

See 4teamwork/ftw.lawgiver#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment