New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also translate states and transitions with their IDs. #76

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@jone
Member

jone commented Dec 5, 2017

In version 1.6.1 we have switched from ID based translations to title based, for states and transitions. See #60

The reason for switching to title based transitions was that some UI components of Plone do translate the title string in the "plone" translation domain. But in catalog based listing usually the id of the statis is translated in the "plone" domain.

For supporting as many places as possible we are now translating states and transition by their titles as well as by their IDs.

For the specification language, these changes can easily be applied by simply regenerating the translations in the lawgiver control panel.

Also translate states and transitions with their IDs.
In version 1.6.1 we have switched from title based translations to
title based, for states and transitions.

The reason for switching to title based transitions was that some UI
components of Plone do translate the title string in the "plone"
translation domain.
But in catalog based listing usually the id of the statis is
translated in the "plone" domain.

For supporting as many places as possible we are now translating
states and transition by their titles as well as by their IDs.

@jone jone requested a review from mbaechtold Dec 5, 2017

@mbaechtold

mbaechtold approved these changes Dec 6, 2017 edited

Cool, the code looks good. But the first sentence of the description of this pull request is a bit weird 😏

@jone

This comment has been minimized.

Show comment
Hide comment
@jone

jone Dec 6, 2017

Member

Ah, yes, multitasking. I updated the description 😉
Thanks!

Member

jone commented Dec 6, 2017

Ah, yes, multitasking. I updated the description 😉
Thanks!

@jone jone merged commit 3807126 into master Dec 6, 2017

4 checks passed

CI Governor: test-plone-4.2.x-deletepermission.cfg Task #201644 succeeded
Details
CI Governor: test-plone-4.3.4-deletepermission.cfg Task #201645 succeeded
Details
CI Governor: test-plone-4.3.x-deletepermission.cfg Task #201646 succeeded
Details
CI Governor: test-plone-4.3.x-no-deletepermission.cfg Task #201647 succeeded
Details

@jone jone deleted the jone-workflow-translations-with-ids branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment