Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize workflow values. #97

Merged
merged 6 commits into from Jan 7, 2020
Merged

Normalize workflow values. #97

merged 6 commits into from Jan 7, 2020

Conversation

@busykoala
Copy link
Contributor

busykoala commented Dec 20, 2019

If transitions are not normalized in Plone 5 it can break because of a translation call in https://github.com/plone/plone.app.content/blob/ab2e5d77ad5f779de04f49631fec4079a1577f48/plone/app/content/browser/contents/workflow.py#L60.
@busykoala busykoala self-assigned this Dec 20, 2019
busykoala added 4 commits Dec 20, 2019
@busykoala busykoala marked this pull request as ready for review Dec 20, 2019
@busykoala busykoala requested a review from 4teamwork/plone Dec 20, 2019
Copy link
Member

jone left a comment

looks good to me 👍
but please add a changelog entry 😉

@jone
jone approved these changes Jan 6, 2020
Copy link
Member

jone left a comment

👍 thank you!

@busykoala busykoala merged commit 6359014 into master Jan 7, 2020
4 checks passed
4 checks passed
CI Governor: test-plone-4.3.x-deletepermission.cfg Task #486569 succeeded
Details
CI Governor: test-plone-4.3.x-no-deletepermission.cfg Task #486570 succeeded
Details
CI Governor: test-plone-5.1.x-deletepermission.cfg Task #486571 succeeded
Details
CI Governor: test-plone-5.1.x-no-deletepermission.cfg Task #486572 succeeded
Details
@busykoala busykoala deleted the mo/normalize branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.