Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version conflicts #64

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@busykoala
Copy link
Contributor

commented Aug 2, 2019

Pandas later than 0.22.x requires python-dateutils>=2.5.0 which conflicts.
Numpy greater than 1.16.x dropped python 2.7 support.

Fix version conflicts
Pandas later than 0.22.x requires python-dateutils>=2.5.0 which conflicts.
Numpy greater than 1.16.x dropped python 2.7 support.

@busykoala busykoala self-assigned this Aug 2, 2019

@busykoala busykoala requested a review from jone Aug 2, 2019

@jone

jone approved these changes Aug 2, 2019

Copy link
Member

left a comment

👍

@@ -11,7 +11,10 @@
'ftw.testing',
'plone.app.testing',
'plone.testing',
'pandas==0.22.0',
# later versions of pandas require python-dateutil>=2.5.0
'pandas < 0.23.0',

This comment has been minimized.

Copy link
@jone

jone Aug 2, 2019

Member

General comment to version constraints:
In the setuptools version comparison function, alpha versions are sorted before betas, betas before stable releases. Thus:
0.23.0a < 0.23.0

So if a pandas==0.23.0a1 would be released, we'd install it.

That's why I usually use:

Suggested change
'pandas < 0.23.0',
'pandas < 0.23a',

This comment has been minimized.

Copy link
@busykoala

busykoala Aug 5, 2019

Author Contributor

I'll put it to my notes. I'm going to merge it like that anyway because it is very unlikely that they will do that and I activated nightly testing (so I'd notice immediately).

@busykoala busykoala merged commit 0aa0843 into master Aug 5, 2019

1 check passed

CI Governor: test-plone-4.3.x.cfg Task #427010 succeeded
Details

@busykoala busykoala deleted the mo/fix_versions branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.