Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log and request using utf-8. #77

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@busykoala
Copy link
Contributor

commented Sep 11, 2019

Not all symbols used in links were in ASCII range. System out was encoding in the standard way (ASCII) and therefore threw an UnicodeEncodeError. Also when links contain umlauts they were not encoded correctly (this actually was the case 馃い).

busykoala added 2 commits Sep 10, 2019
Change link to utf-8 before request done.
Link objects have link_targets saved as unicode strings. Before calling
them with requests we need to encode them.

@busykoala busykoala requested a review from jone Sep 11, 2019

@busykoala busykoala self-assigned this Sep 11, 2019

@jone
jone approved these changes Sep 11, 2019

@busykoala busykoala merged commit a146cb3 into master Sep 11, 2019

1 check passed

CI Governor: test-plone-4.3.x.cfg Task #441499 succeeded
Details

@busykoala busykoala deleted the mo/change_to_utf8 branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.