Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new options to meta.py since we need to support more usecases #20

Merged
merged 3 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@maethu
Copy link
Member

maethu commented Apr 4, 2019

For example if a customer cannot supply a logo in svg, or a icon in svg.

Thus this PR adds the following features:

  • New attrs logo, mobile and favicon for the zcml config in order to manually set those logos and not calculate them.
  • mew attr "primary_logo_scale" in order to always display the logo defined in the logo scale thru zcml.

Those changes only affect the zcml part. If a logo is overriden with the form, this no longer has an effect, since the overrides will win anyway.

@maethu maethu requested a review from jone Apr 4, 2019

@jone

jone approved these changes Apr 4, 2019

Copy link
Member

jone left a comment

👍

@maethu maethu merged commit 693ec4a into master Apr 4, 2019

1 check passed

CI Governor: test-plone-4.3.x.cfg Task #382838 succeeded
Details

@maethu maethu deleted the mle-add-attr-to-meta branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.