Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reindex metadata patch. #41

Merged
merged 4 commits into from Jan 15, 2020
Merged

Conversation

@busykoala
Copy link
Contributor

busykoala commented Jan 14, 2020

Close 4teamwork/izug.organisation#1779

A reindexing metadata patch made it very slow to change the state of an object with many children.
The reindexing of the metadata is now only done if really necessary.

More information is provided in 4teamwork/izug.organisation#1779 (comment)

@busykoala busykoala self-assigned this Jan 14, 2020
This patch made it very slow to change state of an object with many children.
The reindexing of the metadata is now only done if really necessary.
@busykoala busykoala force-pushed the mo/remove_reindex_metadata_patch branch from f6eb881 to d3b3854 Jan 14, 2020
@busykoala busykoala marked this pull request as ready for review Jan 14, 2020
@busykoala busykoala force-pushed the mo/remove_reindex_metadata_patch branch from d902eb6 to 50b17ef Jan 14, 2020
@busykoala busykoala requested a review from 4teamwork/plone Jan 14, 2020
@busykoala

This comment has been minimized.

Copy link
Contributor Author

busykoala commented Jan 14, 2020

@jone could you please look at how I "fixed" tests and give feedback on whether that is done correctly?

ftw/permissionmanager/configure.zcml Outdated Show resolved Hide resolved
ftw/permissionmanager/utils.py Outdated Show resolved Hide resolved
@busykoala busykoala force-pushed the mo/remove_reindex_metadata_patch branch from 7be940f to 720b827 Jan 14, 2020
@busykoala

This comment has been minimized.

Copy link
Contributor Author

busykoala commented Jan 14, 2020

I reacted to the suggested changes in 33786ce.

@busykoala busykoala requested a review from jone Jan 14, 2020
@busykoala busykoala force-pushed the mo/remove_reindex_metadata_patch branch from 720b827 to 33786ce Jan 14, 2020
@jone
jone approved these changes Jan 14, 2020
Copy link
Member

jone left a comment

🎉 thank you!

@busykoala busykoala merged commit fad9a7e into master Jan 15, 2020
2 checks passed
2 checks passed
CI Governor: test-plone-4.3.x.cfg Task #496694 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #496695 succeeded
Details
@busykoala busykoala deleted the mo/remove_reindex_metadata_patch branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.