Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing of types with IShortName behaviour #57

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@Nachtalb
Copy link
Member

Nachtalb commented Nov 5, 2019

The default plone types implement the IShortName behaviour which when
applying on the receiver side wants to rename the existing object to the
same name it already has. But because it already has that name it
appends a -1 and the rest of the publishing fails.

@Nachtalb Nachtalb requested a review from 4teamwork/plone Nov 5, 2019
@Nachtalb Nachtalb self-assigned this Nov 5, 2019
@jone
jone approved these changes Nov 5, 2019
Copy link
Member

jone left a comment

👍 Merci!

@Nachtalb

This comment has been minimized.

Copy link
Member Author

Nachtalb commented Nov 5, 2019

Plone 4 test failed. No IShortName behaviour

The default plone types implement the IShortName behaviour which when
applying on the receiver side wants to rename the existing object to the
same name it already has. But because it already has that name it
appends a -1 and the rest of the publishing fails.
@Nachtalb Nachtalb force-pushed the ne/fix-ishortname-behaviour-publishing branch from 2113846 to 1e215e6 Nov 5, 2019
@Nachtalb Nachtalb requested a review from jone Nov 5, 2019
@jone
jone approved these changes Nov 6, 2019
@Nachtalb Nachtalb merged commit a488ecc into master Nov 6, 2019
2 checks passed
2 checks passed
CI Governor: test-plone-4.3.x.cfg Task #464242 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #464243 succeeded
Details
@Nachtalb Nachtalb deleted the ne/fix-ishortname-behaviour-publishing branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.