Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"_order" Attribute on portlet manager needs to be a persistent list #65

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@maethu
Copy link
Member

maethu commented Feb 5, 2020

Since it set the attr as regular list right now, it leads to strange behavior if you have a multi-instance setup

@maethu maethu requested review from jone and 4teamwork/plone Feb 5, 2020
@jone
jone approved these changes Feb 5, 2020
Copy link
Member

jone left a comment

👍
Is this fix going to auto-repair the data structures when re-publishing the sites? Or is it going to be broken?
If it is auto-reparing I guess we need no upgrade steps..

@maethu

This comment has been minimized.

Copy link
Member Author

maethu commented Feb 5, 2020

👍
Is this fix going to auto-repair the data structures when re-publishing the sites? Or is it going to be broken?
If it is auto-reparing I guess we need no upgrade steps..

I performs an auto repair 😊

@maethu maethu merged commit 17935ef into master Feb 5, 2020
4 checks passed
4 checks passed
CI Governor: test-plone-4.3.x-trash.cfg Task #507226 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #507227 succeeded
Details
CI Governor: test-plone-5.1.x-trash.cfg Task #507228 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #507229 succeeded
Details
@maethu maethu deleted the mle-persistent-order branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.