Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plone5 support #64

Merged
merged 4 commits into from May 17, 2019

Conversation

Projects
None yet
4 participants
@busykoala
Copy link
Contributor

commented Mar 29, 2019

This adds plone 5.1 support to the package.

@busykoala busykoala self-assigned this Mar 29, 2019

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@jone could you look at this assertion failure, because I'm not quite sure if it really is broken or if just the message changed.
https://ci.4teamwork.ch/builds/232084/tasks/380825

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@jone could you look at this assertion failure, because I'm not quite sure if it really is broken or if just the message changed.
https://ci.4teamwork.ch/builds/232084/tasks/380825

I believe that it is broken. But since nothing changed in here it might be an issue of ftw.simplelayout (the failures are both regarding testing publishing simplelayout pages).

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@jone, Ich bin hier noch nicht weitergekommen, um herauszufinden, warum test_warning_on_retract_when_ftw_simplelayout_block_has_published_references nicht klappt. Könntest du dir das einmal anschauen?

Show resolved Hide resolved development.cfg Outdated
@jone

This comment has been minimized.

Copy link
Member

commented May 10, 2019

ftw.simplelayout is in auto-checkout ftw.publisher.sender, so you don't need to wait for the release

@busykoala busykoala requested review from jone and mbaechtold May 10, 2019

Show resolved Hide resolved sources.cfg Outdated

@busykoala busykoala requested a review from mbaechtold May 14, 2019

@busykoala busykoala force-pushed the mo/plone5 branch from f924084 to 61414f4 May 15, 2019

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@mbaechtold, @jone, I merged the commits together to the essential changes. That means I checkout ftw.simplelayout from master (because I need 4teamwork/ftw.simplelayout@5533a3a), for ftw.publisher.core I use the most current release because the branch checked out before is released now plus I activate the test cfg.

@busykoala busykoala force-pushed the mo/plone5 branch from 61414f4 to 64ab235 May 15, 2019

busykoala added some commits May 15, 2019

Use master of ftw.simplelayout
The previously checked out branch plone-5.1.x was merged into
master. We need the unreleased commit 4teamwork/ftw.simplelayout@5533a3a
though and can not use the released version yet.
Use newly released ftw.publisher.core
The master of ftw.publisher.core was released. We can now use
the release instead.

@busykoala busykoala force-pushed the mo/plone5 branch from 64ab235 to dc76933 May 15, 2019

@mbaechtold

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@jone, concerning the methodology, it looks good to me now.

Are you ok with the proposed changes which will re-enable the Plone 5.1.x testing?

@jone
Copy link
Member

left a comment

Looks good to me

Show resolved Hide resolved sources.cfg Outdated
@maethu

maethu approved these changes May 17, 2019

Remove ftw.simplelayout from autocheckout
The feature we were waiting for (commit abc8) was released with
ftw.simplelayout 2.0.2. We can therefore get the package from
pypi.org now.

@busykoala busykoala requested a review from jone May 17, 2019

@busykoala busykoala merged commit 1a59bca into master May 17, 2019

2 checks passed

CI Governor: test-plone-4.3.x.cfg Task #399722 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #399723 succeeded
Details

@busykoala busykoala deleted the mo/plone5 branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.