Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plone5 support #64

Merged
merged 4 commits into from May 17, 2019
Merged
Changes from 3 commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -2,9 +2,7 @@
extends = http://plonesource.org/sources.cfg

auto-checkout =
ftw.publisher.core

# Wait for first release
# Wait for release of https://github.com/4teamwork/ftw.simplelayout/commit/5533a3a2cb9fee8748308e294d1735d38f11d026
This conversation was marked as resolved by mbaechtold

This comment has been minimized.

Copy link
@jone

jone May 15, 2019

Member

is someone going to cut a release in the near future? If so I'd wait and update this PR.

This comment has been minimized.

Copy link
@busykoala

busykoala May 16, 2019

Author Contributor

Thanks! I'll check with @maethu regarding the release.

This comment has been minimized.

Copy link
@maethu

maethu May 17, 2019

Member

Go for the release 😄

This comment has been minimized.

Copy link
@busykoala

busykoala May 17, 2019

Author Contributor

👍 if Pypi's caching is too slow test might fail just now. Otherwise I think we are ready now.

This comment has been minimized.

Copy link
@maethu

maethu May 17, 2019

Member

I approved already ;-)

ftw.simplelayout
This conversation was marked as resolved by mbaechtold

This comment has been minimized.

Copy link
@mbaechtold

mbaechtold May 13, 2019

Member

What is the reason you need to install ftw.simplelayout from source? What feature do you need which has not been released yet?

As I can see in https://github.com/4teamwork/ftw.simplelayout/blob/20904427ba7c5337dd1625fe6892c323a9a77b7d/docs/HISTORY.txt, these are the unreleased changes in ftw.simplelayout:

- Staging: remove auto generated children when creating a working copy. [jone]

- Staging: Add link to working copies in warning message. [mathias.leimgruber]

- Fix plone 4 build by pinning collective.z3cform.datagridfield to 1.4.0. [mathias.leimgruber]

This comment has been minimized.

Copy link
@busykoala

busykoala May 14, 2019

Author Contributor

I forgot to put the changelog there. It is because of reverting commit abc8. The changelog is in review in another pull request, but not yet merged.
If you read the comment above jone told me to put sl into autocheckout ;)

This comment has been minimized.

Copy link
@mbaechtold

extensions = mr.developer
@@ -5,7 +5,3 @@ extends =
versions.cfg

package-name = ftw.publisher.sender


[branches]
ftw.simplelayout = plone-5.1.x
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.