Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plone.protect support #69

Merged
merged 6 commits into from Nov 5, 2019

Conversation

@Nachtalb
Copy link
Member

Nachtalb commented Nov 4, 2019

Resolves #68

See #68 for more details.

By implementing the CSRF protection for the edit realm button we also fix an edit realm view itself. Before it did not fill the edit form because the method leading to the form was GET and the form itself was POST ==> https://github.com/plone/Products.CMFPlone/blob/cf96196e06080fb7fafe57d9454bc2c1f3e3ec58/Products/CMFPlone/patches/z3c_form.py#L14-L35

We don't need "plone.app.referenceablebehavior" in plone 5 anymore and
we can use plones uuid api to get an object by its uuid in plone 4 and 5.
@Nachtalb Nachtalb self-assigned this Nov 4, 2019
@Nachtalb Nachtalb force-pushed the ne/add-plone.protect-support branch 2 times, most recently from a8ebd76 to 39ade16 Nov 5, 2019
@Nachtalb Nachtalb marked this pull request as ready for review Nov 5, 2019
@Nachtalb Nachtalb requested review from jone and 4teamwork/plone Nov 5, 2019
Nachtalb added 2 commits Nov 5, 2019
plone.app.referenceablebehavior is not used anymore in plone 5 so we
make sure that it is only used in plone 4 in the test setup
@Nachtalb Nachtalb force-pushed the ne/add-plone.protect-support branch from 39ade16 to f2c871f Nov 5, 2019
@Nachtalb Nachtalb force-pushed the ne/add-plone.protect-support branch from e6deca5 to faa57af Nov 5, 2019
@Nachtalb Nachtalb force-pushed the ne/add-plone.protect-support branch from faa57af to 8221d2c Nov 5, 2019
@jone
jone approved these changes Nov 5, 2019
Copy link
Member

jone left a comment

👍

@Nachtalb Nachtalb merged commit 380bed4 into master Nov 5, 2019
2 checks passed
2 checks passed
CI Governor: test-plone-4.3.x.cfg Task #464179 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #464180 succeeded
Details
@Nachtalb Nachtalb deleted the ne/add-plone.protect-support branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.