Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect SOLR environment variables. #7

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@jone
Copy link
Member

commented Jul 8, 2019

When a SOLR-env variable is set outside of the startup script, it should be respected. The values generated in the script are now used as default. This makes it possible to change the configuration from outside, for example in tests.

@jone jone requested review from buchi and lukasgraf Jul 8, 2019

Respect SOLR environment variables.
When a SOLR-env variable is set outside of the startup script, it
should be respected.
The values generated in the script are now used as default.
This makes it possible to change the configuration from outside,
for example in tests.

@jone jone force-pushed the jone-configurable-env-variables branch from 323d43e to 62d631b Jul 8, 2019

@buchi

buchi approved these changes Jul 8, 2019

@buchi buchi merged commit cd6a122 into master Jul 8, 2019

1 check passed

CI Governor: test-buildout-2.x.cfg Task #418551 succeeded
Details

@buchi buchi deleted the jone-configurable-env-variables branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.