Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: respect SOLR environment variables. #8

Merged
merged 1 commit into from Jul 10, 2019

Conversation

Projects
None yet
2 participants
@jone
Copy link
Member

commented Jul 10, 2019

When a SOLR-env variable is set outside of the startup script, it should be respected. The values generated in the script are now used as default. This makes it possible to change the configuration from outside, for example in tests.

Backport of #7

Backport: respect SOLR environment variables.
When a SOLR-env variable is set outside of the startup script, it
should be respected.
The values generated in the script are now used as default.
This makes it possible to change the configuration from outside,
for example in tests.

@jone jone requested a review from buchi Jul 10, 2019

@buchi

buchi approved these changes Jul 10, 2019

@buchi buchi merged commit 1673fee into master Jul 10, 2019

1 check passed

CI Governor: default Task #419376 succeeded
Details

@buchi buchi deleted the jone-1.2-env-conf branch Jul 10, 2019

@jone jone restored the jone-1.2-env-conf branch Jul 10, 2019

@jone

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Removed; this shouldn't have gone to master 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.