New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable mapblock. #512

Merged
merged 12 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@maethu
Copy link
Member

maethu commented Jan 16, 2019

To make it work a valid google api key required.

Currently there's a lot from master branches installed, I hope to make some
releases soon.

colorpicker resources are now removed by the mapblock profile.
Also the uninstall test does not work anymore with the current registry.xml provided by the mapblock profile

maethu and others added some commits Jan 15, 2019

Re-enable mapblock.
To make it work a valid google api key required.

Currently there's a lot from master branches installed, I hope to make some
releases soon.
sources.cfg Outdated

[branches]
plonetheme.blueberry = plone51

# https://github.com/collective/collective.geo.mapwidget/pull/31
collective.geo.mapwidget = jone-traversal-error

This comment has been minimized.

@jone

This comment has been minimized.

@jone

jone Jan 22, 2019

Member

@maethu the PR ⬆️ fixes the 404 problem on the dx factory view 😎

@maethu maethu force-pushed the mle-re-enable-mapblock branch from 5492e62 to eae5c50 Jan 23, 2019

@maethu

This comment has been minimized.

Copy link
Member Author

maethu commented Jan 23, 2019

@jone This thing is now ready

@maethu maethu changed the title 🚧 Re-enable mapblock. Re-enable mapblock. Jan 31, 2019

@jone

jone approved these changes Feb 4, 2019

Copy link
Member

jone left a comment

Looks good.
Maybe this is worth a changelog entry?

Show resolved Hide resolved ftw/simplelayout/mapblock/hooks.py Outdated

@maethu maethu force-pushed the mle-re-enable-mapblock branch from 9cf2efc to da23d73 Feb 4, 2019

@maethu maethu merged commit a148785 into plone-5.1.x Feb 4, 2019

3 checks passed

CI Governor: test-javascript.cfg Task #361644 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #361645 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #361646 succeeded
Details

@maethu maethu deleted the mle-re-enable-mapblock branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment