Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commit removing IReferenceable and add tests #526

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@busykoala
Copy link
Contributor

commented May 10, 2019

The commit abc8 mistakenly removed IReferenceable in plone4. In consequence references were not added to the reference catalog. This adds it again plus a test showing that it is working again.

Reverse commit removing IReferenceable in Plone4
So that relation are saved to the relation catalog we need to have
plone.app.referenceablebehavior.referenceable.IReferenceable installed in
Plone4. We removed that by mistake and did only find out about now.

@busykoala busykoala force-pushed the mo/fix_sl_references_plone4 branch from f9eb6fe to 0044d49 May 10, 2019

@busykoala busykoala self-assigned this May 10, 2019

@busykoala busykoala force-pushed the mo/fix_sl_references_plone4 branch 2 times, most recently from 5efd9a7 to 63a7604 May 10, 2019

@jone

jone approved these changes May 10, 2019

Copy link
Member

left a comment

Could you add a changelog entry?
What was the missing part that the tests now pass?

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Could you add a changelog entry?
What was the missing part that the tests now pass?

They do not pass yet. I try printing the html into the output now to find out.

@busykoala busykoala force-pushed the mo/fix_sl_references_plone4 branch from 63a7604 to 5533a3a May 10, 2019

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

The test mentioned won't pass because ftw.trash overwrites the deleting method. I removed this test because of that.

@busykoala busykoala merged commit 2090442 into master May 10, 2019

3 checks passed

CI Governor: test-javascript.cfg Task #397150 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #397151 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #397152 succeeded
Details

@busykoala busykoala deleted the mo/fix_sl_references_plone4 branch May 10, 2019

@jone

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@busykoala you were missing the changelog entry, could you add it?

@busykoala

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@jone I commited this just minutes after I mistakenly merged it without
#527.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.