Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save translation to match the rest of plone in plone 4 / 5 #554

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@Nachtalb
Copy link
Member

Nachtalb commented Oct 31, 2019

In plone 4 the "Save" from PloneMessageFactory translates to "Sichern" whereas the rest of plone uses "Speichern" from plone.dexterity.i18n. So we use this as well to make sure the "Save" message is the same across the site and across plone versions.

@Nachtalb Nachtalb requested a review from 4teamwork/plone Oct 31, 2019
@Nachtalb Nachtalb self-assigned this Oct 31, 2019
Copy link
Member

jone left a comment

@Nachtalb could you add a changelog entry, saying that the label is now fixed / consistent?

@Nachtalb

This comment has been minimized.

Copy link
Member Author

Nachtalb commented Oct 31, 2019

Oops, yeah let me do that quickly...

@Nachtalb Nachtalb force-pushed the ne/fix-save-translation branch from a4cc0c1 to 27832c4 Oct 31, 2019
@Nachtalb

This comment has been minimized.

Copy link
Member Author

Nachtalb commented Oct 31, 2019

Done

@Nachtalb Nachtalb requested a review from jone Oct 31, 2019
@busykoala busykoala self-requested a review Oct 31, 2019
Copy link
Contributor

busykoala left a comment

Looks good! 🐳

@jone
jone approved these changes Nov 1, 2019
Copy link
Member

jone left a comment

👍 thank you!

@Nachtalb Nachtalb force-pushed the ne/fix-save-translation branch from 27832c4 to 45086de Nov 6, 2019
@Nachtalb

This comment has been minimized.

Copy link
Member Author

Nachtalb commented Nov 6, 2019

Rebased onto latest master.

@Nachtalb Nachtalb merged commit 035efd9 into master Nov 6, 2019
3 checks passed
3 checks passed
CI Governor: test-javascript.cfg Task #464660 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #464661 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #464662 succeeded
Details
@Nachtalb Nachtalb deleted the ne/fix-save-translation branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.