Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair overlay styles #583

Merged
merged 1 commit into from Jan 7, 2020
Merged

Repair overlay styles #583

merged 1 commit into from Jan 7, 2020

Conversation

@djowett-ftw
Copy link
Contributor

djowett-ftw commented Jan 6, 2020

Resolves 4teamwork/izug.organisation#1720

Looking somewhat better

Screenshot 2020-01-06 at 15 50 27

Screenshot 2020-01-06 at 15 52 24

Screenshot 2020-01-06 at 15 57 47

Screenshot 2020-01-06 at 15 52 03

referencewidget could be clearer on styling expandable (traversable) items, but I guess that's a different issue

@djowett-ftw djowett-ftw requested a review from 4teamwork/plone Jan 6, 2020
@djowett-ftw

This comment has been minimized.

Copy link
Contributor Author

djowett-ftw commented Jan 6, 2020

Checked this in Plone 4 with blueberry theme and seems ok, though the referencewidget overlay is the same size as the overlay behind it....

Screenshot 2020-01-06 at 16 48 54

Screenshot 2020-01-06 at 16 49 06

Screenshot 2020-01-06 at 16 49 22

@djowett-ftw

This comment has been minimized.

Copy link
Contributor Author

djowett-ftw commented Jan 6, 2020

Without the blueberry theme (or ftw.theming) activated, this looks as follows - but we don't have a plain CSS in this product to fix it....

Screenshot 2020-01-06 at 16 26 36

Copy link
Member

jone left a comment

Yay, cool 🎉

Could you make a changelog entry? 😉

@djowett-ftw djowett-ftw force-pushed the dj_repair_overlay_styles branch from 3d27e99 to c2f65bf Jan 7, 2020
@djowett-ftw

This comment has been minimized.

Copy link
Contributor Author

djowett-ftw commented Jan 7, 2020

Yay, cool 🎉

Could you make a changelog entry? 😉

Good point! and ... done :-)

@jone
jone approved these changes Jan 7, 2020
@djowett-ftw djowett-ftw merged commit 6b3cb4f into master Jan 7, 2020
3 checks passed
3 checks passed
CI Governor: test-javascript.cfg Task #492892 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #492893 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #492894 succeeded
Details
@djowett-ftw djowett-ftw deleted the dj_repair_overlay_styles branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.